From bd7b15f347818bbb95ca9261f433883d49a56c2e Mon Sep 17 00:00:00 2001 From: Kristian Rietveld Date: Tue, 14 Aug 2007 08:11:26 +0000 Subject: [PATCH] make sure we fail keynav if the only item in the list is already selected. 2007-08-14 Kristian Rietveld * gtk/gtktreeview.c (gtk_tree_view_move_cursor_up_down): make sure we fail keynav if the only item in the list is already selected. (Fixes #465039, reported by Fernando Herrera). svn path=/trunk/; revision=18610 --- ChangeLog | 6 ++++++ gtk/gtktreeview.c | 5 +++-- 2 files changed, 9 insertions(+), 2 deletions(-) diff --git a/ChangeLog b/ChangeLog index cb552cd99d..d0ca452fc4 100644 --- a/ChangeLog +++ b/ChangeLog @@ -1,3 +1,9 @@ +2007-08-14 Kristian Rietveld + + * gtk/gtktreeview.c (gtk_tree_view_move_cursor_up_down): make + sure we fail keynav if the only item in the list is already selected. + (Fixes #465039, reported by Fernando Herrera). + 2007-08-09 Sven Neumann * modules/printbackends/file/gtkprintbackendfile.c: change the diff --git a/gtk/gtktreeview.c b/gtk/gtktreeview.c index 65c1a17f3f..3812a37e5b 100644 --- a/gtk/gtktreeview.c +++ b/gtk/gtktreeview.c @@ -9596,7 +9596,7 @@ gtk_tree_view_move_cursor_up_down (GtkTreeView *tree_view, /* * If the list has only one item and multi-selection is set then select - * the row. + * the row (if not yet selected). */ if (tree_view->priv->selection->type == GTK_SELECTION_MULTIPLE && new_cursor_node == NULL) @@ -9608,7 +9608,8 @@ gtk_tree_view_move_cursor_up_down (GtkTreeView *tree_view, _gtk_rbtree_prev_full (cursor_tree, cursor_node, &new_cursor_tree, &new_cursor_node); - if (new_cursor_node == NULL) + if (new_cursor_node == NULL + && !GTK_RBNODE_FLAG_SET (cursor_node, GTK_RBNODE_IS_SELECTED)) { new_cursor_node = cursor_node; new_cursor_tree = cursor_tree; -- 2.30.2